Re: [PATCH] tpm: ibmvtpm: retry on H_CLOSED in tpm_ibmvtpm_send()

[George Wilson]

On Thu, Feb 27, 2020 at 06:23:39PM +0200, Jarkko Sakkinen wrote:
> On Thu, Feb 27, 2020 at 10:50:03AM -0500, George Wilson wrote:
> > tpm_ibmvtpm_send() can fail during LPM resume with an H_CLOSED return
> > from ibmvtpm_send_crq().  The PAPR says, 'The âpartner partition
> > suspendedâ transport event disables the associated CRQ such that any
> > H_SEND_CRQ hcall() to the associated CRQ returns H_Closed until the CRQ
> > has been explicitly enabled using the H_ENABLE_CRQ hcall.' This patch
> > adds a check in tpm_ibmvtpm_send() for an H_CLOSED return from
> > ibmvtpm_send_crq() and in that case calls tpm_ibmvtpm_resume() and
> > retries the ibmvtpm_send_crq() once.
> > 
> > Reported-by: Linh Pham <phaml@xxxxxxxxxx>
> > Reviewed-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>
> > Signed-off-by: George Wilson <gcwilson@xxxxxxxxxxxxx>
> 
> What is LPM anyway?

It's PowerVM Live Partition Mobility.

> 
> /Jarkko

-- 
George Wilson
IBM Linux Technology Center
Security Development