RE: [PATCH v1 0/4] platform/x86: intel_pmc_core: Add bug fixes or code

[Kammela, Gayatri]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Thursday, February 27, 2020 1:57 AM
> To: Kammela, Gayatri <gayatri.kammela@xxxxxxxxx>
> Cc: platform-driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> Somayaji, Vishwanath <vishwanath.somayaji@xxxxxxxxx>;
> dvhart@xxxxxxxxxxxxx; Westerberg, Mika <mika.westerberg@xxxxxxxxx>;
> peterz@xxxxxxxxxxxxx; Prestopine, Charles D
> <charles.d.prestopine@xxxxxxxxx>; Chen Zhou <chenzhou10@xxxxxxxxxx>;
> Box, David E <david.e.box@xxxxxxxxx>
> Subject: Re: [PATCH v1 0/4] platform/x86: intel_pmc_core: Add bug fixes or
> code
> 
> On Wed, Feb 26, 2020 at 06:43:26PM -0800, Gayatri Kammela wrote:
> > Hi,
> >
> > This patch series consists of bug fixes and code optimization for the
> > series https://patchwork.kernel.org/patch/11365325/
> >
> > Patch 1: Make pmc_core_lpm_display() generic Patch 2: Relocate both
> > pmc_core_slps0_display() and pmc_core_lpm_display() Patch 3: Remove
> > the duplicate if() condition to create debugfs entry Patch 4: Add back
> > slp_s0_offset attribute back to tgl_reg_map
> 
> Let's do other way around, i.e. patch 2 as a first in the series, so I may fix the
> current (visible) issue.

Hi Andy,  sure I will change the order and send the version 2

> 
> Then fix the kbuild bot complains and send the rest.

Sure, I will do that. Thanks!

> 
> >
> > Gayatri Kammela (4):
> >   platform/x86: intel_pmc_core: fix: Make pmc_core_lpm_display() generic
> >     for platforms that support sub-states
> >   platform/x86: intel_pmc_core: fix: Relocate pmc_core_slps0_display()
> >     and pmc_core_lpm_display() to outside of CONFIG_DEBUG_FS
> >   platform/x86: intel_pmc_core: fix: Remove the duplicate if() to create
> >     debugfs entry for substate_live_status_registers
> >   platform/x86: intel_pmc_core: fix: Add slp_s0_offset attribute back to
> >     tgl_reg_map
> >
> >  drivers/platform/x86/intel_pmc_core.c | 131
> > +++++++++++++-------------
> >  1 file changed, 66 insertions(+), 65 deletions(-)
> >
> > Cc: Chen Zhou <chenzhou10@xxxxxxxxxx>
> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Cc: David Box <david.e.box@xxxxxxxxx>
> > --
> > 2.17.1
> >
> 
> --
> With Best Regards,
> Andy Shevchenko
>