Re: [PATCH v3 0/2] perf report: Support annotation of code without symbols

[Arnaldo Carvalho de Melo]

Em Mon, Feb 24, 2020 at 10:22:23AM +0800, Jin Yao escreveu:
> For perf report on stripped binaries it is currently impossible to do
> annotation. The annotation state is all tied to symbols, but there are
> either no symbols, or symbols are not covering all the code.
> 
> We should support the annotation functionality even without symbols.
> 
> The first patch uses al_addr to print because it's easy to dump
> the instructions from this address in binary for branch mode.
> 
> The second patch supports the annotation on stripped binary.

I'm considering this a new feature, so I'll leave this for perf/core,
i.e. for the next release, ok?

I'm now going thru the pure fixes that should go to perf/urgent, please
holler if something you think should go in now is not in my perf/urgent
branch.

- Arnaldo
 
>  v3:
>  ---
>  Keep just the ANNOTATION_DUMMY_LEN, and remove the
>  opts->annotate_dummy_len since it's the "maybe in future
>  we will provide" feature.
> 
>  v2:
>  ---
>  Fix a crash issue when annotating an address in "unknown" object.
> 
> Jin Yao (2):
>   perf util: Print al_addr when symbol is not found
>   Support interactive annotation of code without symbols
> 
>  tools/perf/ui/browsers/hists.c | 43 +++++++++++++++++++++++++++++-----
>  tools/perf/util/annotate.h     |  1 +
>  tools/perf/util/sort.c         |  6 +++--
>  3 files changed, 42 insertions(+), 8 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 

- Arnaldo