Re: [PATCH 0/8] perf annotate/config: More fixes

[Arnaldo Carvalho de Melo]

Em Thu, Feb 27, 2020 at 02:16:48PM +0100, Jiri Olsa escreveu:
> On Thu, Feb 27, 2020 at 10:08:46AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sun, Feb 16, 2020 at 10:15:49PM +0100, Jiri Olsa escreveu:
> > > On Thu, Feb 13, 2020 at 12:12:58PM +0530, Ravi Bangoria wrote:
> > > > These are the additional set of fixes on top of previous series:
> > > > http://lore.kernel.org/r/20200204045233.474937-1-ravi.bangoria@xxxxxxxxxxxxx
> > > > 
> > > > Note for the last patch:
> > > > I couldn't understand what intel-pt.cache-divisor is really used for.
> > > > Adrian, can you please help.
> > > > 
> > > > Ravi Bangoria (8):
> > > >   perf annotate/tui: Re-render title bar after switching back from
> > > >     script browser
> > > >   perf annotate: Fix --show-total-period for tui/stdio2
> > > >   perf annotate: Fix --show-nr-samples for tui/stdio2
> > > >   perf config: Introduce perf_config_u8()
> > > >   perf annotate: Make perf config effective
> > > >   perf annotate: Prefer cmdline option over default config
> > > >   perf annotate: Fix perf config option description
> > > >   perf config: Document missing config options
> > > 
> > > nice, I guess this all worked in the past but got broken because
> > > we don't have any tests for annotation code.. any chance you could
> > 
> > I'm going thru them, can I take that "nice" as an Acked-by? Have you
> > gone thru those patches?
> 
> nope, I just real fast checked on them.. I expected more discussion on tests ;-)

Ok, I tested all of the patches, and merged them, thanks,

- Arnaldo
 
> but as Ravi wrote, it could take some time
> 
> jirka
> 
> > 
> > - Arnaldo
> > 
> > > think of some way to test annotations?
> >  
> > > perhaps some shell script, or prepare all the needed data for annotation
> > > manualy.. sort of like we did in tests/hists_*.c
> > > 
> > > thanks,
> > > jirka
> > > 
> > > > 
> > > >  tools/perf/Documentation/perf-config.txt | 74 +++++++++++++++++++-
> > > >  tools/perf/builtin-annotate.c            |  4 +-
> > > >  tools/perf/builtin-report.c              |  2 +-
> > > >  tools/perf/builtin-top.c                 |  2 +-
> > > >  tools/perf/ui/browsers/annotate.c        | 19 +++--
> > > >  tools/perf/util/annotate.c               | 89 +++++++++---------------
> > > >  tools/perf/util/annotate.h               |  6 +-
> > > >  tools/perf/util/config.c                 | 12 ++++
> > > >  tools/perf/util/config.h                 |  1 +
> > > >  9 files changed, 134 insertions(+), 75 deletions(-)
> > > > 
> > > > -- 
> > > > 2.24.1
> > > > 
> > > 
> > 
> > -- 
> > 
> > - Arnaldo
> > 
> 

-- 

- Arnaldo