Re: [patch 01/15] x86/irq: Convey vector as argument and not in ptregs

From: Thomas Gleixner
Date: Wed Feb 26 2020 - 18:50:54 EST


Andy Lutomirski <luto@xxxxxxxxxxxxxx> writes:
>> On Feb 26, 2020, at 12:13 PM, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> ïBrian Gerst <brgerst@xxxxxxxxx> writes:
>> Now the question is whether we care about the packed stubs or just make
>> them larger by using alignment to get rid of this silly +0x80 and
>> ~vector fixup later on. The straight forward thing clearly has its charm
>> and I doubt it matters in measurable ways.
>
> I agree it probably doesnât matter. That being said, I have a distinct
> memory of fixing that asm so it would fail the build if the alignment
> was off.

Hrm. Doesn't look like. Gah, and I love the hardcoded * 8 in the IDT
code. Let me add something to catch such things in the future.

Thanks,

tglx