Re: [PATCH v2] dt-bindings: mmc: Convert Cadence SD/SDIO/eMMC controller to json-schema

From: Rob Herring
Date: Wed Feb 26 2020 - 17:23:14 EST


On Sat, 22 Feb 2020 23:34:44 +0900, Masahiro Yamada wrote:
> Convert the Cadence SD/SDIO/eMMC host controller IP (a.k.a. SD4HC)
> binding to DT schema format.
>
> Socionext UniPhier ARM 64-bit SoCs are integrated with this IP.
>
> Cc: Piotr Sroka <piotrs@xxxxxxxxxxx>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> ---
>
> I wanted to keep some precious comments, which apply to multiple
> properties.
>
> I do not think 'description:' is a good fit for this.
>
> I was searching for a way to insert a comment line that does not
> affect the schema.
>
> The $comment did not work. I just use '#', which is YAML comment.
> If there is a better way, please let me know.
>
>
> Changes in v2:
> - fix schema warning in example
>
> .../devicetree/bindings/mmc/cdns,sdhci.yaml | 143 ++++++++++++++++++
> .../devicetree/bindings/mmc/sdhci-cadence.txt | 80 ----------
> 2 files changed, 143 insertions(+), 80 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> delete mode 100644 Documentation/devicetree/bindings/mmc/sdhci-cadence.txt
>

Applied, thanks.

Rob