Re: [PATCH v9 3/4] soc: mediatek: Move mt8173 MMSYS to platform driver

From: Ezequiel Garcia
Date: Wed Feb 26 2020 - 15:29:53 EST


On Wed, 2020-02-26 at 07:40 -0800, Randy Dunlap wrote:
> On 2/26/20 2:54 AM, Enric Balletbo i Serra wrote:
> > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
> > index 2114b563478c..dcd6481a14d0 100644
> > --- a/drivers/soc/mediatek/Kconfig
> > +++ b/drivers/soc/mediatek/Kconfig
> > @@ -44,4 +44,11 @@ config MTK_SCPSYS
> > Say yes here to add support for the MediaTek SCPSYS power domain
> > driver.
> >
> > +config MT8173_MMSYS
> > + bool "MediaTek MT8173 MMSYS Support"
>
> Hi,
> Can this be tristate instead of bool?
>

Wouldn't that conflict with
the driver being a builtin_platform_driver,
or am I just confusing things badly?

Thanks,
Ezequiel

> + depends on COMMON_CLK_MT8173
> > + help
> > + Say yes here to add support for the MediaTek MT8173 Multimedia
> > + Subsystem (MMSYS).
> > +
> > endmenu
>
> thanks.
> --
> ~Randy
>
>