Re: [patch 16/16] x86/entry: Disable interrupts in IDTENTRY

[Thomas Gleixner]

Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:

> On Tue, Feb 25, 2020 at 11:33:37PM +0100, Thomas Gleixner wrote:
>> Not all exceptions guarantee to return with interrupts disabled. Disable
>> them in idtentry_exit() which is invoked on all regular (non IST) exception
>> entry points. Preparatory patch for further consolidation of the return
>> code.
>
> ISTR a patch that undoes cond_local_irq_enable() in the various trap
> handlers. Did that get lost or is that still on the TODO list
> somewhere?

Hmm. I ditched it after we decided that fixing the #PF cases is ugly as
hell. Lemme find that stuff again.

> Once we do that, this can turn into an assertion that IRQs are in fact
> disabled.

Right.

Thanks,

        tglx