Re: [PATCH v2 02/18] ARM: replace setup_irq() by request_irq()

From: Tony Lindgren
Date: Wed Feb 26 2020 - 11:31:47 EST


* afzal mohammed <afzal.mohd.ma@xxxxxxxxx> [200224 00:49]:
> request_irq() is preferred over setup_irq(). The early boot setup_irq()
> invocations happen either via 'init_IRQ()' or 'time_init()', while
> memory allocators are ready by 'mm_init()'.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> Seldom remove_irq() usage has been observed coupled with setup_irq(),
> wherever that has been found, it too has been replaced by free_irq().
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@xxxxxxxxx>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> Acked-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> # EP93xx
> Tested-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> # EP93xx

Works for me:

Tested-by: Tony Lindgren <tony@xxxxxxxxxxx> # omap1 osk