Re: [PATCH 02/61] KVM: x86: Refactor loop around do_cpuid_func() to separate helper

From: Paolo Bonzini
Date: Wed Feb 26 2020 - 06:35:16 EST


On 25/02/20 16:09, Vitaly Kuznetsov wrote:
>> Apart from the stupidity of the above case, why would it be EINVAL?
>>
> I suggested -EINVAL because issuing KVM_GET_SUPPORTED_CPUID with nent=0
> looks more like a completely invalid input and not 'too many
> entries'(-E2BIG) to me (but -E2BIG is already there, let's keep it, it's
> not a big deal).

Yes, and in fact he already does that change a few patches later.

Paolo