Re: [PATCH v2 1/5] mfd: rk808: Always use poweroff when requested

[Lee Jones]

On Sun, 12 Jan 2020, Robin Murphy wrote:

> From: Soeren Moch <smoch@xxxxxx>
> 
> With the device tree property "rockchip,system-power-controller" we
> explicitly request to use this PMIC to power off the system. So always
> register our poweroff function, even if some other handler (probably
> PSCI poweroff) was registered before.
> 
> This does tend to reveal a warning on shutdown due to the Rockchip I2C
> driver not implementing an atomic transfer method, however since the
> write to DEV_OFF takes effect immediately the I2C completion interrupt
> is moot anyway, and as the very last thing written to the console it is
> only visible to users going out of their way to capture serial output.
> 
> Signed-off-by: Soeren Moch <smoch@xxxxxx>
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
> [ rm: note potential warning in commit message ]
> Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>
> ---
>  drivers/mfd/rk808.c | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)

Applied, thanks.

-- 
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog