Re: [PATCH 2/3] sched/debug: Bunch up printing formats in common macros

From: Valentin Schneider
Date: Wed Feb 26 2020 - 05:15:24 EST




On 26/02/2020 07:21, Tao Zhou wrote:
>> @@ -963,8 +962,7 @@ void proc_sched_show_task(struct task_struct *p, struct pid_namespace *ns,
>>
>> t0 = cpu_clock(this_cpu);
>> t1 = cpu_clock(this_cpu);
>> - SEQ_printf(m, "%-45s:%21Ld\n",
>> - "clock-delta", (long long)(t1-t0));
>> + __PS("clock-delta", t1-t0);
>
> __PS("clock-delta", (t1-t0));

Oh snap indeed! I think I may just as well shove parentheses in the macro
definitions.

Thanks.

>
> Thanks,
> Tao
>> }
>>
>> sched_show_numa(p, m);
>> --
>> 2.24.0
>>