Re: [PATCH 1/2] USB: core: Fix build warning in usb_get_configuration()

[Tiezhu Yang]

On 02/26/2020 04:04 PM, Johan Hovold wrote:
> On Wed, Feb 26, 2020 at 02:15:22PM +0800, Tiezhu Yang wrote:
> > There is no functional issue, just fix the following build warning:
> >
> >    CC      drivers/usb/core/config.o
> > drivers/usb/core/config.c: In function âusb_get_configurationâ:
> > drivers/usb/core/config.c:868:6: warning: âresultâ may be used uninitialized in this function [-Wmaybe-uninitialized]
> >    int result;
> >        ^
> What compiler are you using? The warning is clearly bogus and it hasn't
> been seen with any recent gcc at least.

[yangtiezhu@linux ~]$ gcc --version
gcc (GCC) 4.9.4 20160726 (Red Hat 4.9.4-14)
Copyright (C) 2015 Free Software Foundation, Inc.

The gcc version I used maybe too old,
if the warning is bogus, please ignore this patch.

Thanks,

Tiezhu Yang

> > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> > ---
> >   drivers/usb/core/config.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
> > index b7918f6..bb63ee0 100644
> > --- a/drivers/usb/core/config.c
> > +++ b/drivers/usb/core/config.c
> > @@ -865,7 +865,7 @@ int usb_get_configuration(struct usb_device *dev)
> >   	unsigned int cfgno, length;
> >   	unsigned char *bigbuffer;
> >   	struct usb_config_descriptor *desc;
> > -	int result;
> > +	int result = 0;
> >   
> >   	if (ncfg > USB_MAXCONFIG) {
> >   		dev_warn(ddev, "too many configurations: %d, "
> Johan