Re: [PATCH v3 bpf-next] RV32G eBPF JIT

From: Song Liu
Date: Tue Feb 25 2020 - 17:56:15 EST


On Tue, Feb 25, 2020 at 10:37 AM Luke Nelson <lukenels@xxxxxxxxxxxxxxxxx> wrote:
>
>
> > I found a lot of common code between RV32G and RV64G. Can we move
> > these code into a header file?
>
> Certainly! I was planning on doing this in a separate patch to minimize the changes
> to the RV64 JIT. I can also do it in another revision of this patch if that seems like a better idea.

I would recommend expand this patch into two patches: one patch moves
common code
to a header, the other adds logic for RV32G.

Thanks,
Song