Re: [PATCH] selftests/timers: Turn off timeout setting

From: Po-Hsu Lin
Date: Tue Feb 25 2020 - 11:26:56 EST


Sure,
I will send V2 that include the change for makefile and more detail
about the change.
Thanks for the feedback,

On Tue, Feb 25, 2020 at 11:30 PM shuah <shuah@xxxxxxxxxx> wrote:
>
> On 2/25/20 3:18 AM, Po-Hsu Lin wrote:
> > Tests in timers especially nsleep-lat, set-timer-lat,
> > inconsistency-check and raw_skew these 4 tests can take longer than
> > the default 45 seconds that introduced in commit 852c8cbf
> > (selftests/kselftest/runner.sh: Add 45 second timeout per test) to run.
> >
> > Disable the timeout setting for timers instead of looking for an proper
> > value to make it more general.
> >
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx>
> > ---
> > tools/testing/selftests/timers/settings | 1 +
> > 1 file changed, 1 insertion(+)
> > create mode 100644 tools/testing/selftests/timers/settings
> >
> > diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> > new file mode 100644
> > index 0000000..e7b9417
> > --- /dev/null
> > +++ b/tools/testing/selftests/timers/settings
> > @@ -0,0 +1 @@
> > +timeout=0
> >
>
> What happens when you disable this and set it to 0? How long does the
> rest run in this case? Can you add the details to the change log please.
>
> thanks,
> -- Shuah