Re: [PATCH -next] drm/amd/powerplay: Use bitwise instead of arithmetic operator for flags

[Alex Deucher]

On Sun, Feb 23, 2020 at 10:21 PM Quan, Evan <Evan.Quan@xxxxxxx> wrote:
>
> Thanks. Reviewed-by: Evan Quan <evan.quan@xxxxxxx>
>

Applied.  Thanks!

Alex

> -----Original Message-----
> From: Chen Zhou <chenzhou10@xxxxxxxxxx>
> Sent: Friday, February 21, 2020 8:22 PM
> To: Quan, Evan <Evan.Quan@xxxxxxx>; Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>; Zhou, David(ChunMing) <David1.Zhou@xxxxxxx>; airlied@xxxxxxxx; daniel@xxxxxxxx
> Cc: Feng, Kenneth <Kenneth.Feng@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; chenzhou10@xxxxxxxxxx
> Subject: [PATCH -next] drm/amd/powerplay: Use bitwise instead of arithmetic operator for flags
>
> This silences the following coccinelle warning:
>
> "WARNING: sum of probable bitmasks, consider |"
>
> Signed-off-by: Chen Zhou <chenzhou10@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 92a65e3d..f29f95b 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -3382,7 +3382,7 @@ static int vega10_populate_and_upload_sclk_mclk_dpm_levels(
>         }
>
>         if (data->need_update_dpm_table &
> -                       (DPMTABLE_OD_UPDATE_SCLK + DPMTABLE_UPDATE_SCLK + DPMTABLE_UPDATE_SOCCLK)) {
> +                       (DPMTABLE_OD_UPDATE_SCLK | DPMTABLE_UPDATE_SCLK |
> +DPMTABLE_UPDATE_SOCCLK)) {
>                 result = vega10_populate_all_graphic_levels(hwmgr);
>                 PP_ASSERT_WITH_CODE((0 == result),
>                                 "Failed to populate SCLK during PopulateNewDPMClocksStates Function!", @@ -3390,7 +3390,7 @@ static int vega10_populate_and_upload_sclk_mclk_dpm_levels(
>         }
>
>         if (data->need_update_dpm_table &
> -                       (DPMTABLE_OD_UPDATE_MCLK + DPMTABLE_UPDATE_MCLK)) {
> +                       (DPMTABLE_OD_UPDATE_MCLK | DPMTABLE_UPDATE_MCLK)) {
>                 result = vega10_populate_all_memory_levels(hwmgr);
>                 PP_ASSERT_WITH_CODE((0 == result),
>                                 "Failed to populate MCLK during PopulateNewDPMClocksStates Function!",
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx