Re: [PATCH 0/3] Unexport kallsyms_lookup_name() and kallsyms_on_each_symbol()

From: Miroslav Benes
Date: Tue Feb 25 2020 - 05:05:44 EST


CC live-patching ML, because this could affect many of its users...

On Fri, 21 Feb 2020, Will Deacon wrote:

> Hi folks,
>
> Despite having just a single modular in-tree user that I could spot,
> kallsyms_lookup_name() is exported to modules and provides a mechanism
> for out-of-tree modules to access and invoke arbitrary, non-exported
> kernel symbols when kallsyms is enabled.
>
> This patch series fixes up that one user and unexports the symbol along
> with kallsyms_on_each_symbol(), since that could also be abused in a
> similar manner.
>
> Cheers,
>
> Will
>
> Cc: K.Prasad <prasad@xxxxxxxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Frederic Weisbecker <frederic@xxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Quentin Perret <qperret@xxxxxxxxxx>
> Cc: Alexei Starovoitov <ast@xxxxxxxxxx>
> Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
>
> --->8
>
> Will Deacon (3):
> samples/hw_breakpoint: Drop HW_BREAKPOINT_R when reporting writes
> samples/hw_breakpoint: Drop use of kallsyms_lookup_name()
> kallsyms: Unexport kallsyms_lookup_name() and
> kallsyms_on_each_symbol()
>
> kernel/kallsyms.c | 2 --
> samples/hw_breakpoint/data_breakpoint.c | 11 ++++++++---
> 2 files changed, 8 insertions(+), 5 deletions(-)
>
> --
> 2.25.0.265.gbab2e86ba0-goog
>