Re: [PATCH] KVM: LAPIC: Recalculate apic map in batch

[Wanpeng Li]

On Tue, 25 Feb 2020 at 16:07, Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>
> On 19/02/20 01:47, Wanpeng Li wrote:
> >> An alternative idea: instead of making every caller return bool and
> >> every call site handle the result (once) just add a
> >> KVM_REQ_APIC_MAP_RECALC flag or a boolean flag to struct kvm. I
> >> understand it may not be that easy as it sounds as we may be conunting
> >> on valid mapping somewhere before we actually get to handiling
> > Yes.
> >
> >> KVM_REQ_APIC_MAP_RECALC but we may preserve *some*
> >> recalculate_apic_map() calls (and make it reset KVM_REQ_APIC_MAP_RECALC).
> > Paolo, keep the caller return bool or add a booleen flag to struct
> > kvm, what do you think?
>
> A third possibility: add an apic_map field to struct kvm_lapic, so that
> you don't have to add bool return values everywhere.

This apic_map field is boolean, right?

    Wanpeng