Re: [PATCH] ARM: dts: sun8i-a83t: Add thermal trip points/cooling maps

[Maxime Ripard]

On Sun, Feb 23, 2020 at 11:10:50AM +0100, OndÅej Jirman wrote:
> Hello,
>
> On Sun, Feb 23, 2020 at 11:29:07AM +0800, Chen-Yu Tsai wrote:
> > Hi,
> >
> > On Sun, Feb 23, 2020 at 5:40 AM Ondrej Jirman <megous@xxxxxxxxxx> wrote:
> > >
> > > This enables passive cooling by down-regulating CPU voltage
> > > and frequency.
> >
> > Please state for the record how the trip points were derived. Were they from
> > the BSP? Or the user manual?
>
> The values are taken from the BSP for A83T:
>
> https://megous.com/git/linux/tree/drivers/thermal/sunxi-temperature.c?h=a83t-3.4-bsp-tbs-a711#n747
>
> The datasheet only mentions recommended Ta (ambient operating temperature) range
> -20 to +70ÂC. So die voltages will be larger than that. I guess that roughly
> matches the BSP values.

Can you put that in the commit log?

Thanks!
Maxime

Attachment: signature.asc
Description: PGP signature