Re: [PATCH] drm: aspeed: Fix GENMASK misuse

From: Andrew Jeffery
Date: Sun Feb 23 2020 - 19:07:00 EST




On Sun, 23 Feb 2020, at 10:21, Ondrej Jirman wrote:
> Arguments to GENMASK should be msb >= lsb.
>
> Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx>
> ---
> I just grepped the whole kernel tree for GENMASK argument order issues,
> and this is one of the three that popped up. No testing was done.

I think someone's sent a patch previously, and last time it turned into a
discussion about how the macros aren't actually used and could be
removed.

Regardless:

Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>