Re: [PATCH] soc: amlogic: fix compile failure with MESON_SECURE_PM_DOMAINS & !MESON_SM

[Stephen Rothwell]

Hi all,

On Tue, 18 Feb 2020 09:22:29 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 18 Feb 2020 08:07:43 +1100 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, 18 Feb 2020 00:12:13 +0800 Jianxin Pan <jianxin.pan@xxxxxxxxxxx> wrote:  
> > >
> > > When MESON_SECURE_PM_DOMAINS & !MESON_SM, there will be compile failure:
> > > .../meson-secure-pwrc.o: In function `meson_secure_pwrc_on':
> > > .../meson-secure-pwrc.c:76: undefined reference to `meson_sm_call'
> > > 
> > > Fix this by adding depends on MESON_SM for MESON_SECURE_PM_DOMAINS.
> > > 
> > > Fixes: b3dde5013e13 ("soc: amlogic: Add support for Secure power domains controller")
> > > 
> > > Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> > > Reported-by: patchwork-bot+linux-amlogic<patchwork-bot+linux-amlogic@xxxxxxxxxx>
> > > Reported-by: Stephen Rothwell<sfr@xxxxxxxxxxxxxxxx>
> > > Signed-off-by: Jianxin Pan <jianxin.pan@xxxxxxxxxxx>
> > > ---
> > >  drivers/soc/amlogic/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)    
> > 
> > I will apply that patch to linux-next today.  
> 
> This fixes the build for me.
> 
> Tested-by: Stephen Rothwell<sfr@xxxxxxxxxxxxxxxx>
> 
> Also, please keep the commit message tags together at the end of the
> commit message i.e. remove the blank line after the Fixes: tag above.
> (see "git interpret-trailers ")

I am still applying this patch ...
-- 
Cheers,
Stephen Rothwell

Attachment: pgpTsa5Cvz161.pgp
Description: OpenPGP digital signature