Re: [RFC][PATCH v2 23/34] merging pick_link() with get_link(), part 6

From: Linus Torvalds
Date: Sat Feb 22 2020 - 21:28:09 EST


On Sat, Feb 22, 2020 at 5:23 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> - err = pick_link(nd, &path, inode, seq);
> - if (err > 0)
> - return get_link(nd);
> - else
> - return ERR_PTR(err);
> + return pick_link(nd, &path, inode, seq);

Yay! It's like Christmas.

Except honestly, I think I'd have been happier if the intermediate
points didn't have that odd syntax in them. Even if it then gets
removed in the end.

Linus