Re: [PATCH v4] leds: add SGI IP30 led support

[Thomas Bogendoerfer]

On Fri, 21 Feb 2020 21:31:04 +0100
Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx> wrote:


> > +	if (num == 0)
> > +		data->cdev.name = "white:indicator";
> > +	else
> > +		data->cdev.name = "red:indicator";
> 
> Why indicator? Whereas it sounds quite generic it is used in the LED
> subsystem specifically for naming indicator LEDs, that are often
> found on flash LED controllers and are designed to indicate camera
> sensor activity.

ok, ic.

> If it is on the front panel of SGI Octane workstations then its
> function is perhaps well known?

the red LED is clearly a fault led. The white LED will be switch on
after system diagnostic was successfull. Nothing from common.h really
fits that, maybe status ?

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Felix Imendörffer