Re: [PATCH v26 22/22] docs: x86/sgx: Document SGX micro architecture and kernel internals

From: Randy Dunlap
Date: Fri Feb 21 2020 - 23:32:04 EST


Hi Jarkko,

One minor fix below:


On 2/9/20 1:26 PM, Jarkko Sakkinen wrote:
> Document Intel SGX micro architecture and kernel internals. The motivation
> is to make the core ideas approachable by keeping a fairly high abstraction
> level. Fine-grained micro architecture details can be looked up from Intel
> SDM Volume 3D.
>
> Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> Cc: linux-doc@xxxxxxxxxxxxxxx
> Co-developed-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>
> ---
> Documentation/x86/index.rst | 1 +
> Documentation/x86/sgx.rst | 182 ++++++++++++++++++++++++++++++++++++
> 2 files changed, 183 insertions(+)
> create mode 100644 Documentation/x86/sgx.rst
>
> diff --git a/Documentation/x86/sgx.rst b/Documentation/x86/sgx.rst
> new file mode 100644
> index 000000000000..ccffb45b4f4d
> --- /dev/null
> +++ b/Documentation/x86/sgx.rst
> @@ -0,0 +1,182 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +============
> +Architecture
> +============
> +
> +Introduction
> +============
> +
> +*Software Guard eXtensions (SGX)* is a set of instructions that enable ring-3
> +applications to set aside private regions of code and data. These regions are
> +called enclaves. An enclave can be entered to a fixed set of entry points. Only
> +a CPU running inside the enclave can access its code and data.
> +
> +SGX support can be determined by
> +
> + ``grep /proc/cpuinfo``

grep sgx /proc/cpuinfo

> +
> +Enclave Page Cache
> +==================

...

and
Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
--
~Randy