Re: [PATCH V4 03/13] fs: Remove unneeded IS_DAX() check

From: Ira Weiny
Date: Fri Feb 21 2020 - 18:04:25 EST


On Fri, Feb 21, 2020 at 12:42:25PM +1100, Dave Chinner wrote:
> On Thu, Feb 20, 2020 at 04:41:24PM -0800, ira.weiny@xxxxxxxxx wrote:
> > From: Ira Weiny <ira.weiny@xxxxxxxxx>
> >
> > Remove the check because DAX now has it's own read/write methods and
> > file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on
> > their own. Therefore, it does not matter if the file state is DAX when
> > the iocb flags are created.
> >
> > Reviewed-by: Jan Kara <jack@xxxxxxx>
> > Signed-off-by: Ira Weiny <ira.weiny@xxxxxxxxx>
>
> Yup, looks good.
>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Thanks,
Ira

> --
> Dave Chinner
> david@xxxxxxxxxxxxx