Re: [PATCH] random: always use batched entropy for get_random_u{32,64}

From: Jason A. Donenfeld
Date: Fri Feb 21 2020 - 15:08:03 EST


Hi Tony,

On Thu, Feb 20, 2020 at 11:20 PM Tony Luck <tony.luck@xxxxxxxxx> wrote:
>
> On Sun, Feb 16, 2020 at 10:24 AM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > > drivers/char/random.c | 12 ------------
> > > 1 file changed, 12 deletions(-)
> >
> > Looks good to me, thank for doing this:
> >
> > Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> Perhaps also needs to update the comment above these functions.
>
> Specifically the bit that says "The quality of the random
> number is either as good as RDRAND" ... since you are
> no longer pulling from RDRAND it isn't true anymore.

Good call. I'll fix up this comment and submit v2.


Jason