Re: [PATCH v3 4/5] sched/pelt: Add a new runnable average signal

[Vincent Guittot]

On Fri, 21 Feb 2020 at 10:45, Dietmar Eggemann <dietmar.eggemann@xxxxxxx> wrote:
>
> On 19/02/2020 13:55, Vincent Guittot wrote:
>
> [...]
>
> > +static inline long se_runnable(struct sched_entity *se)
> > +{
>
> Why returning long here? sched_entity::runnable_weight is unsigned long
> but could be unsigned int (cfs_rq::h_nr_running is unsigned int).

I have reused the same prototype as for runnable_laod_avg

>
> ___update_load_sum() has 'unsigned long runnable' as parameter.