Re: [PATCH] tracing: Skip software disabled event at __synth_event_trace_end()

From: Steven Rostedt
Date: Thu Feb 20 2020 - 14:34:17 EST


On Mon, 17 Feb 2020 18:33:40 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> > static inline void
> > __synth_event_trace_end(struct synth_event_trace_state *trace_state)
> > {
> > + if (trace_state->disabled)
> > + return;
> > +
>
> Aah, I assumed that trace_state should be initialized with 0, but
> in really, it could be just allocated on the stack.
> We has to set trace_state->disabled = false in __synth_event_trace_start().

Is this patch good enough to take, or is there another one coming?

-- Steve