Re: [PATCH -next] pinctrl: mediatek: remove set but not used variable 'e'

From: Linus Walleij
Date: Thu Feb 20 2020 - 10:14:20 EST


On Tue, Feb 18, 2020 at 3:36 AM YueHaibing <yuehaibing@xxxxxxxxxx> wrote:

> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c: In function mtk_hw_pin_field_lookup:
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:70:39: warning:
> variable e set but not used [-Wunused-but-set-variable]
>
> Since commit 3de7deefce69 ("pinctrl: mediatek: Check gpio pin
> number and use binary search in mtk_hw_pin_field_lookup()"),
> it is not used any more, so remove it, also remove redundant
> assignment to variable c, it will be assigned a new value later
> before used.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Patch applied with Matthias Review tag.

Yours,
Linus Walleij