Re: w83627ehf crash in 5.6.0-rc2-00055-gca7e1fd1026c

From: Dr. David Alan Gilbert
Date: Thu Feb 20 2020 - 08:57:17 EST


* Meelis Roos (mroos@xxxxxxxx) wrote:
> > It looks like not all chips have temp_label, so I think we need to change w83627ehf_is_visible
> > which has:
> >
> > if (attr == hwmon_temp_input || attr == hwmon_temp_label)
> > return 0444;
> >
> > to
> > if (attr == hwmon_temp_input)
> > return 0444;
> > if (attr == hwmon_temp_label) {
> > if (data->temp_label)
> > return 0444;
> > else
> > return 0;
> > }
> >
> > Does that work for you?
> Yes, it works - sensors are displayed as they should be, with nothing in dmesg.
>
> Thank you for so quick response!

Great, I need to turn that into a proper patch; (I might need to wait till
Saturday for that, although if someone needs it before then please shout).

Dave

>
> --
> Meelis Roos <mroos@xxxxxxxx>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/