Re: [PATCH 1/6] drm/bridge: anx6345: Fix getting anx6345 regulators

From: Laurent Pinchart
Date: Thu Feb 20 2020 - 08:47:06 EST


Hi Vasily,

Thank you for the patch.

On Thu, Feb 20, 2020 at 12:35:03AM -0800, Vasily Khoruzhick wrote:
> From: Samuel Holland <samuel@xxxxxxxxxxxx>
>
> We don't need to pass '-supply' suffix to devm_get_regulator()
>
> Fixes: 6aa192698089 ("drm/bridge: Add Analogix anx6345 support")
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
> Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
> drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> index 56f55c53abfd..0d8d083b0207 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix-anx6345.c
> @@ -712,14 +712,14 @@ static int anx6345_i2c_probe(struct i2c_client *client,
> DRM_DEBUG("No panel found\n");
>
> /* 1.2V digital core power regulator */
> - anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12-supply");
> + anx6345->dvdd12 = devm_regulator_get(dev, "dvdd12");
> if (IS_ERR(anx6345->dvdd12)) {
> DRM_ERROR("dvdd12-supply not found\n");
> return PTR_ERR(anx6345->dvdd12);
> }
>
> /* 2.5V digital core power regulator */
> - anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25-supply");
> + anx6345->dvdd25 = devm_regulator_get(dev, "dvdd25");
> if (IS_ERR(anx6345->dvdd25)) {
> DRM_ERROR("dvdd25-supply not found\n");
> return PTR_ERR(anx6345->dvdd25);

--
Regards,

Laurent Pinchart