Re: [for-next][PATCH 12/26] Documentation: bootconfig: Add a doc for extended boot config

From: Masami Hiramatsu
Date: Thu Feb 20 2020 - 08:13:49 EST


Hi,

On Thu, 20 Feb 2020 10:10:20 +0100
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> I wonder about a few details in the added text.
>
>
>
> > +++ b/Documentation/admin-guide/bootconfig.rst
>
> > +C onfig File Limitation
>
> How do you think about to omit a space character at the beginning
> of this line?

That was my mistake. I used restructured text extension for vim
which collapsed all sections and use "space" key to expand.
Accidentally, I run into edit mode and hit "space" to expand it.
(it actually expanded but also put a space there and I missed it...)

Anyway, it has been fixed (pointed by Rundy)

> > +Currently the maximum config size size is 32KB …
>
> Would you like to avoid a word duplication here?

Oops, still exist. Thanks!


> > +Note: this is not the number of entries but nodes, an entry must consume
> > +more than 2 nodes (a key-word and a value). …
>
> I find the relevance of the term “nodes” unclear at the moment.

Indeed, "node" is not well defined. What about this?
---
Each key consists of words separated by dot, and value also consists of
values separated by comma. Here, each word and each value is generally
called a "node".
---

>
> Could an other wording be nicer than the abbreviation “a doc for … config”
> in the commit subject?

OK, I'll try next time.

Thank you,

--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>