Re: [PATCH][resend] KVM: fix error handling in svm_cpu_init

From: linmiaohe
Date: Thu Feb 20 2020 - 03:40:51 EST


Li,Rongqing <lirongqing@xxxxxxxxx> writes:
>> Hi,
>> Li RongQing <lirongqing@xxxxxxxxx> writes:
>> >
>> >sd->save_area should be freed in error path
>> Oh, it's strange. This is already fixed in my previous patch : [PATCH v2] KVM:
>> SVM: Fix potential memory leak in svm_cpu_init().
>> And Vitaly and Liran gave me Reviewed-by tags and Paolo queued it one
>> month ago. But I can't found it in master or queue branch. There might
>> be something wrong. :(
>
>In fact, I send this patch 2019/02/, and get Reviewed-by, but did not queue
>
>https://patchwork.kernel.org/patch/10853973/
>
>and resend it 2019/07
>
>https://patchwork.kernel.org/patch/11032081/
>

Oh, it's really a pit. And in this case, we can get rid of the var r as '-ENOMEM' is actually the only possible outcome here, as
suggested by Vitaly, which looks like this: https://lkml.org/lkml/2020/1/15/933
Thanks. :)