Re: [PATCH net-next v2 10/13] net: socionext: use new helper tcp_v6_gso_csum_prep

From: Ilias Apalodimas
Date: Wed Feb 19 2020 - 07:36:37 EST


On Tue, Feb 18, 2020 at 09:09:17PM +0100, Heiner Kallweit wrote:
> Use new helper tcp_v6_gso_csum_prep in additional network drivers.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> ---
> drivers/net/ethernet/socionext/netsec.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c
> index e8224b543..6266926fe 100644
> --- a/drivers/net/ethernet/socionext/netsec.c
> +++ b/drivers/net/ethernet/socionext/netsec.c
> @@ -1148,11 +1148,7 @@ static netdev_tx_t netsec_netdev_start_xmit(struct sk_buff *skb,
> ~tcp_v4_check(0, ip_hdr(skb)->saddr,
> ip_hdr(skb)->daddr, 0);
> } else {
> - ipv6_hdr(skb)->payload_len = 0;
> - tcp_hdr(skb)->check =
> - ~csum_ipv6_magic(&ipv6_hdr(skb)->saddr,
> - &ipv6_hdr(skb)->daddr,
> - 0, IPPROTO_TCP, 0);
> + tcp_v6_gso_csum_prep(skb);
> }
>
> tx_ctrl.tcp_seg_offload_flag = true;
> --
> 2.25.1
>
>

Acked-by: Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>