Re: [PATCH v3 11/25] inode: inode_owner_or_capable(): handle fsid mappings

From: Christian Brauner
Date: Wed Feb 19 2020 - 07:30:05 EST


On Tue, Feb 18, 2020 at 02:25:23PM -0800, Christoph Hellwig wrote:
> On Tue, Feb 18, 2020 at 03:33:57PM +0100, Christian Brauner wrote:
> > + if (is_userns_visible(inode->i_sb->s_iflags)) {
> > + if (kuid_has_mapping(ns, inode->i_uid) && ns_capable(ns, CAP_FOWNER))
> > + return true;
> > + } else if (kfsuid_has_mapping(ns, inode->i_uid) && ns_capable(ns, CAP_FOWNER)) {
>
> This adds some crazy long unreadable lines..

I'll ad a helper in the next version or wrap those lines depending on
what makes more sense.