Re: [PATCH v4 1/3] kbuild: allow symbol whitelisting with TRIM_UNUSED_KSYMS

[Matthias Maennich]

On Mon, Feb 17, 2020 at 11:00:39AM -0500, Nicolas Pitre wrote:
> On Mon, 17 Feb 2020, Quentin Perret wrote:
>
> > On Monday 17 Feb 2020 at 15:22:01 (+0000), Matthias Maennich wrote:
> > > In case the whitelist file can't be found, the error message is
> > >
> > >  cat: path/to/file: file not found
> > >
> > > I wonder whether we can make this error message a bit more specific by
> > > telling the user that the KSYMS_WHITELIST is missing.
> >
> > +1, that'd be really useful. I'll check the file existence in v5 (in a
> > POSIX-compliant way, I promise).
>
> In fact, if you explicitly provide a file that is not there, then this
> is arguably a good reason to even fail the build.

I agree, I would expect the build to fail in that case.

Cheers,
Matthias

> Nicolas