Re: [PATCH] extcon: Remove unneeded extern keyword from extcon-provider.h

From: Greg KH
Date: Mon Feb 17 2020 - 05:45:22 EST


On Mon, Feb 17, 2020 at 07:47:28PM +0900, Chanwoo Choi wrote:
> The commit tb7365587f513 ("extcon: Remove unneeded extern keyword
> from extcon.h") removes the unneeded extern keyword from extcon header
> file. But, The commit tb7365587f513 has missed that deletes 'extern'
> keyword from extcon-provider.h. So that it deletes extern keyword
> from extcon-provider.h.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
> Dear Greg,
>
> When I removed the unneeded extern keyword from extcon hearder file for
> v5.6-rc1, although I should remove 'extern' keyword on both extcon.h
> and extcon-provider.h, I only removed them from extcon.h. It was my mistake.
>
> So that I send this patch for v5.6-rc3 release.
> Could you review and apply it to char-misc git repository directly?

Sure, but it's not really a bugfix, I'll queue it up for 5.7-rc1, ok?

thanks,

greg k-h