Re: [PATCH 1/8] ASoC: sun50i-codec-analog: Fix duplicate use of ADC enable bits

From: Chen-Yu Tsai
Date: Sun Feb 16 2020 - 22:28:28 EST


On Mon, Feb 17, 2020 at 10:18 AM Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
>
> The same enable bits are currently used for both the "Left/Right ADC"
> and the "Left/Right ADC Mixer" widgets. This happens to work in practice
> because the widgets are always enabled/disabled at the same time, but
> each register bit should only be associated with a single widget.
>
> To keep symmetry with the DAC widgets, keep the bits on the ADC widgets,
> and remove them from the ADC Mixer widgets.
>
> Fixes: 42371f327df0 ("ASoC: sunxi: Add new driver for Allwinner A64 codec's analog path controls")
> Reported-by: Ondrej Jirman <megous@xxxxxxxxxx>
> Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>