[PATCH AUTOSEL 5.4 332/459] gpio: Fix the no return statement warning

From: Sasha Levin
Date: Fri Feb 14 2020 - 12:25:02 EST


From: Kevin Hao <haokexin@xxxxxxxxx>

[ Upstream commit 9c6722d85e92233082da2b3623685bba54d6093e ]

In commit 242587616710 ("gpiolib: Add support for the irqdomain which
doesn't use irq_fwspec as arg") we have changed the return type of
gpiochip_populate_parent_fwspec_twocell/fourcell() from void to void *,
but forgot to add a return statement for these two dummy functions.
Add "return NULL" to fix the build warnings.

Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Signed-off-by: Kevin Hao <haokexin@xxxxxxxxx>
Link: https://lore.kernel.org/r/20200116095003.30324-1-haokexin@xxxxxxxxx
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
---
include/linux/gpio/driver.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 5dd9c982e2cbe..d7dc2b425532e 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -545,6 +545,7 @@ static inline void gpiochip_populate_parent_fwspec_twocell(struct gpio_chip *chi
unsigned int parent_hwirq,
unsigned int parent_type)
{
+ return NULL;
}

static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *chip,
@@ -552,6 +553,7 @@ static inline void gpiochip_populate_parent_fwspec_fourcell(struct gpio_chip *ch
unsigned int parent_hwirq,
unsigned int parent_type)
{
+ return NULL;
}

#endif /* CONFIG_IRQ_DOMAIN_HIERARCHY */
--
2.20.1