Re: vhost changes (batched) in linux-next after 12/13 trigger random crashes in KVM guests after reboot

From: Christian Borntraeger
Date: Fri Feb 14 2020 - 07:22:56 EST




On 14.02.20 13:17, Eugenio PÃrez wrote:
> Can you try the inlined patch over 52c36ce7f334 ("vhost: use batched version by default")? My intention is to check if
> "strange VHOST_SET_VRING_BASE" line appears. In previous tests, it appears very fast, but maybe it takes some time for
> it to appear, or it does not appear anymore.

LD [M] drivers/vhost/vhost_vsock.o
CC [M] drivers/vhost/vhost.o
In file included from ./include/linux/printk.h:331,
from ./include/linux/kernel.h:15,
from ./include/linux/list.h:9,
from ./include/linux/wait.h:7,
from ./include/linux/eventfd.h:13,
from drivers/vhost/vhost.c:13:
drivers/vhost/vhost.c: In function âfetch_descsâ:
drivers/vhost/vhost.c:2330:56: error: âstruct vhost_virtqueueâ has no member named âfirst_descâ
2330 | vq, vq->last_avail_idx, vq->avail_idx, vq->ndescs, vq->first_desc);
| ^~
./include/linux/dynamic_debug.h:125:15: note: in definition of macro â__dynamic_func_callâ
125 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
./include/linux/dynamic_debug.h:153:2: note: in expansion of macro â_dynamic_func_callâ
153 | _dynamic_func_call(fmt, __dynamic_pr_debug, \
| ^~~~~~~~~~~~~~~~~~
./include/linux/printk.h:335:2: note: in expansion of macro âdynamic_pr_debugâ
335 | dynamic_pr_debug(fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~
drivers/vhost/vhost.c:2328:2: note: in expansion of macro âpr_debugâ
2328 | pr_debug(
| ^~~~~~~~
make[2]: *** [scripts/Makefile.build:266: drivers/vhost/vhost.o] Error 1
make[1]: *** [scripts/Makefile.build:503: drivers/vhost] Error 2