Re: [patch V2 02/17] ARM: vdso: Remove unused function

From: Vincenzo Frascino
Date: Fri Feb 14 2020 - 05:22:13 EST


On 2/7/20 12:38 PM, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>
> The function is nowhere used. Aside of that this check should only cover
> the high resolution parts of the VDSO which require a VDSO capable
> clocksource and not the complete functionality as the name suggests. Will
> be replaced with something more useful.
>
> Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>
Tested-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

> ---
> arch/arm/include/asm/vdso/vsyscall.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> --- a/arch/arm/include/asm/vdso/vsyscall.h
> +++ b/arch/arm/include/asm/vdso/vsyscall.h
> @@ -50,13 +50,6 @@ int __arm_get_clock_mode(struct timekeep
> #define __arch_get_clock_mode __arm_get_clock_mode
>
> static __always_inline
> -int __arm_use_vsyscall(struct vdso_data *vdata)
> -{
> - return vdata[CS_HRES_COARSE].clock_mode;
> -}
> -#define __arch_use_vsyscall __arm_use_vsyscall
> -
> -static __always_inline
> void __arm_sync_vdso_data(struct vdso_data *vdata)
> {
> flush_dcache_page(virt_to_page(vdata));
>

--
Regards,
Vincenzo