Re: Remove WQ_CPU_INTENSIVE flag from unbound wq's

From: Maksym Planeta
Date: Thu Feb 13 2020 - 11:19:22 EST




On 13/02/2020 16:36, Mike Snitzer wrote:
On Thu, Feb 13 2020 at 9:18am -0500,
Maksym Planeta <mplaneta@xxxxxxxxxxxxxxxxxxxx> wrote:

The documentation [1] says that WQ_CPU_INTENSIVE is "meaningless" for
unbound wq. I remove this flag from places where unbound queue is
allocated. This is supposed to improve code readability.

1. https://www.kernel.org/doc/html/latest/core-api/workqueue.html#flags

Signed-off-by: Maksym Planeta <mplaneta@xxxxxxxxxxxxxxxxxxxx>

What the Documentation says aside, have you cross referenced with the
code? And/or have you done benchmarks to verify no changes?


It seems so from the code. Although, I'm not 100% confident. I did not run benchmarks, instead I relied that on the assumption that documentation is correct.

Thanks,
Mike


--
Regards,
Maksym Planeta