Re: [PATCH] KVM: x86: enable -Werror

From: Paolo Bonzini
Date: Thu Feb 13 2020 - 04:54:44 EST


On 13/02/20 04:31, Joe Perches wrote:
> On Thu, 2020-02-13 at 01:40 +0000, linmiaohe wrote:
>> Paolo Bonzini <pbonzini@xxxxxxxxxx> wrote:
>>> Avoid more embarrassing mistakes. At least those that the compiler can catch.
>>>
>>> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
>>> ---
>
> I think adding -Werror is a bad idea as new versions of compilers can
> create additional compilation warnings and break builds in the
> future.
Seems like cargo culting (in the reverse) to me. We can cross the
bridge when we get there.

Paolo