RE: [PATCH v3 3/3] PCI: hv: Introduce hv_msi_entry

[Dexuan Cui]

> From: Boqun Feng <boqun.feng@xxxxxxxxx>
> Sent: Wednesday, February 12, 2020 11:14 PM
> 
> On Thu, Feb 13, 2020 at 04:18:01AM +0000, Dexuan Cui wrote:
> > > From: linux-hyperv-owner@xxxxxxxxxxxxxxx
> > > <linux-hyperv-owner@xxxxxxxxxxxxxxx> On Behalf Of Boqun Feng
> > > diff --git a/arch/x86/include/asm/hyperv-tlfs.h
> > > b/arch/x86/include/asm/hyperv-tlfs.h
> > >
> > > +union hv_msi_entry {
> > > +	u64 as_uint64;
> > > +	struct {
> > > +		u32 address;
> > > +		u32 data;
> > > +	} __packed;
> > > +};
> >
> > Just a small thing: should we move the __packed to after the "}" of
> > the union hv_msi_entry ?
> >
> 
> Actually, in TLFS header, it's common to put the "__packed" inside the
> union, rather than after the union. It makes sense because union is
> different than struct: the alignment requirement of a union is already
> decided by the "as_*" member, so no need for "__packed" attribute.
> 
> Regards,
> Boqun

I see. Thanks for the explanation!

Thanks,
-- Dexuan