[PATCH 1/4] ASoC: codec2codec: avoid invalid/double-free of pcm runtime

From: Samuel Holland
Date: Thu Feb 13 2020 - 01:12:01 EST


The PCM runtime was freed during PMU in the case that the event hook
encountered an error. However, it is also unconditionally freed during
PMD. Avoid a double-free by dropping the call to kfree in the PMU hook.

Fixes: a72706ed8208 ("ASoC: codec2codec: remove ephemeral variables")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx>
---
sound/soc/soc-dapm.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index b6378f025836..935b5375ecc5 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3888,9 +3888,6 @@ snd_soc_dai_link_event_pre_pmu(struct snd_soc_dapm_widget *w,
runtime->rate = params_rate(params);

out:
- if (ret < 0)
- kfree(runtime);
-
kfree(params);
return ret;
}
--
2.24.1