Re: [PATCH v3 3/6] ASoC: qdsp6: q6afe-dai: add support to pcm port dais

[Srinivas Kandagatla]

On 12/02/2020 09:52, Srinivas Kandagatla wrote:
> On 12/02/2020 01:52, Adam Serbinski wrote:
> > +ÂÂÂÂÂÂÂÂÂÂÂ ret = of_property_read_u32(node, "qcom,pcm-quantype",
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ &priv->quantype);
> > +ÂÂÂÂÂÂÂÂÂÂÂ if (ret) {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ dev_err(dev, "No quantype from DT\n");
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ break;
> > +ÂÂÂÂÂÂÂÂÂÂÂ }
> > +
> > +ÂÂÂÂÂÂÂÂÂÂÂ ret = of_property_read_variable_u32_array(node,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ "qcom,pcm-slot-mapping",
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ priv->slot_number_mapping,
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ 1, AFE_MAX_PCM_SLOT_COUNT);
>
> These new bindings needs to be documented in 
> Documentation/devicetree/bindings/sound/qcom,q6afe.txt

Replied too quickly!

I would normally have expected bindings patch before this patch though..

--srini

> --srini