Re: [PATCH] microblaze: Fix unistd_32.h generation format

From: Arnd Bergmann
Date: Wed Feb 12 2020 - 03:38:24 EST


On Wed, Feb 12, 2020 at 8:56 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
>
> Generated files are also checked by sparse that's why add newline
> to remove sparse (C=1) warning:
> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
> warning: no newline at end of file
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> Reviewed-by: Stefan Asserhall <stefan.asserhall@xxxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

The patch looks good, but if you don't mind respinning it, could respin
it to do the same thing for all architectures at once? I see that some
already have it, but most don't.

> ---
>
> arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/microblaze/kernel/syscalls/syscallhdr.sh b/arch/microblaze/kernel/syscalls/syscallhdr.sh
> index 2e9062a926a3..4f4238433644 100644
> --- a/arch/microblaze/kernel/syscalls/syscallhdr.sh
> +++ b/arch/microblaze/kernel/syscalls/syscallhdr.sh
> @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
> printf "#endif\n"
> printf "\n"
> printf "#endif /* %s */" "${fileguard}"
> + printf "\n"
> ) > "$out"
> --
> 2.25.0
>