Re: [PATCH] Removing a duplicate condition.

From: Alexei Starovoitov
Date: Tue Feb 11 2020 - 10:08:41 EST


On Tue, Feb 11, 2020 at 5:26 AM Isaac Young <isaac.young5@xxxxxxxxx> wrote:
>
> Signed-off-by: Isaac Young <isaac.young5@xxxxxxxxx>
> ---
> tools/testing/selftests/bpf/prog_tests/select_reuseport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> index 098bcae5f827..0954c7a8aa08 100644
> --- a/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> +++ b/tools/testing/selftests/bpf/prog_tests/select_reuseport.c
> @@ -823,7 +823,7 @@ void test_select_reuseport(void)
>
> saved_tcp_fo = read_int_sysctl(TCP_FO_SYSCTL);
> saved_tcp_syncookie = read_int_sysctl(TCP_SYNCOOKIE_SYSCTL);
> - if (saved_tcp_syncookie < 0 || saved_tcp_syncookie < 0)
> + if (saved_tcp_syncookie < 0)
> goto out;

please resend this patch to bpf@vger and cc maintainers.
Also see bpf_devel_QA.rst
Thanks