RE: [PATCH 1/2 V2] mfd: constify properties in mfd_cell

From: Winkler, Tomas
Date: Sun Feb 09 2020 - 06:58:28 EST



>
> On Sat, Feb 8, 2020 at 8:44 PM Tomas Winkler <tomas.winkler@xxxxxxxxx>
> wrote:
> >
> > Constify 'struct property_entry *properties' in mfd_cell It is always
> > passed around as a pointer const struct.
>
> I guess this should be second patch in the split and it's actually dependent to the
> first one (won't we get a compiler warning when we drop const qualifier during
> assignment?).
>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> > ---
> >
> > V2: drop platform_device part
>
> Btw, when you prepare series, you may use -vX command line parameter,
> where X is a version number. The scripts will put v2 in each Subject line
> uniformly.
Right, just the second patch was a new one, so not sure I should mark it v2.
Thanks
Tomas