Re: [PATCH v5 11/18] usb: dwc3: Add support for a role-switch notifier

From: Jack Pham
Date: Fri Feb 07 2020 - 19:15:33 EST


Hi Bryan,

On Fri, Feb 07, 2020 at 08:16:47PM +0000, Bryan O'Donoghue wrote:
> Role-switching is a 1:1 mapping between a producer and a consumer. For DWC3
> we have some vendor specific wrappers, notably the qcom wrapper that want
> to toggle some PHY related bits on a USB role switch.
>
> This patch adds a role-switch notifier to the dwc3 drd code. When the USB
> role-switch set() routine runs, the notifier will fire passing the notified
> mode to the consumer, thus allowing vendor specific fix-ups to toggle from
> the role-switching events.

Neat! This could work. But let's see if Felipe likes this approach.

If you need, here's a

Reviewed-by: Jack Pham <jackp@xxxxxxxxxxxxxx>

Jack
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project